return the proxy mode in the server type for stdio #1975
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the server type display logic to show the effective transport type (proxy mode) instead of the underlying transport type when listing MCP servers that use stdio with a proxy. This provides more accurate information to users about what they're actually connecting to.
- Adds logic to determine effective transport type based on proxy mode for stdio servers
- Updates the display to show proxy mode (sse or streamable-http) instead of stdio when applicable
- Adds comprehensive test coverage for the new transport type resolution logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/thv/app/list.go | Implements getEffectiveTransportType function and updates server listing to use effective transport type |
| cmd/thv/app/list_test.go | Adds comprehensive unit tests for the new transport type resolution logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
+ Coverage 47.11% 47.35% +0.23%
==========================================
Files 231 233 +2
Lines 28378 28665 +287
==========================================
+ Hits 13369 13573 +204
- Misses 14011 14076 +65
- Partials 998 1016 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
when we run a server via stdio, we wrap it into a proxy, exposing via sse or streamable-http. So show this as the server type, instead of the stdio type Closes: #1717
ok fixed |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yrobla
force-pushed
the
issue-1717
branch
3 times, most recently
from
430f37e to
fb87216
Compare
| // For direct transports (sse, streamable-http), return the transport type as proxy mode | ||
| if transportType == types.TransportTypeSSE || transportType == types.TransportTypeStreamableHTTP { | ||
| return transportType.String() | ||
| } | ||
|
|
||
| // For stdio without proxy mode or other cases, return original proxy mode (could be empty) | ||
| return proxyMode |
There was a problem hiding this comment.
Drop lines 128-131 and just return transportType.String()
when we run a server via stdio, we wrap it into a proxy, exposing via sse or streamable-http. So show this as the server type, instead of the stdio type
Closes: #1717