Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement type normalization #15
base: main
Are you sure you want to change the base?
Implement type normalization #15
Changes from 12 commits
fffb5b5
644ed70
9302ec9
056ba4d
2640182
0b78983
2061904
bb99f98
b39e8e6
fa39ef0
fc53c29
c1de1a5
71aff30
b135099
206fe0a
d5b047a
84c2bd6
b4a470c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a way to access the types that have been composed. Even though they don't need to be recursively normalized, I think it'd still be good to represent them as
NormalizedSimpleType
s so that they can be used as if they've been normalized.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based the implementation of
NormalizedCompositionType
onCompositionType
, that has no direct way to access the sub-types. Should I still implement this property onNormalizedCompositionType
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a way to access the root and member types (as normalized types). Same goes for any other normalized types which don't have such properties yet (they should have a simple way to pull out their normalized component parts).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #15 (comment) above,
MemberType
does not have any direct way to access such properties.