Backport PowerVM+shfmt+gperf fixes on 3.21 (4.7) #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Afsan Hossain <[email protected]>
The lint CI job has started failing because the go version required by the latest release of shfmt is higher than the one being installed on the fedora:40 image. We could bump the image, but for now I think pinning the shfmt version would lead to the least pain in the future.
ovalenti
changed the title
When we removed the /module mount from the collector daemonset we inadvertedly broke the gperftool cpu profiler, since it was using that directory for dumping its output files. This patch moves the dump directory to /var/profiles, which will be a new emptydir mount on the collector daemonset. A new test is also added to ensure the profiles still starts, stops and produces some output.
ovalenti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2038, #2055 and #2066
Those PRs address respectively:
Checklist