Skip to content

Make ansible playbooks and CI actions compatible with stackrox/fact #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Jul 31, 2025

Description

The setup-vm-creds action has been modified so it can be called from repositories other than this one. This enables re-using it in fact (see stackrox/fact#4).

Additionally, the fedora-coreos provisioning has been simplified to not require a reboot after installing python by using the --apply-live flag. The --idempotent flag also mean the operation will not fail if the provisioning script is called multiple times.

Finally, the ansible community module is changed to require at least version 10.1.0, this makes it possible to use the apply_live option in the rpm_ostree_pkg module, which is useful in the previously mentioned fact PR.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI should be enough.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.83%. Comparing base (c4637b5) to head (9d83327).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2307   +/-   ##
=======================================
  Coverage   28.83%   28.83%           
=======================================
  Files          96       96           
  Lines        5799     5799           
  Branches     2551     2551           
=======================================
  Hits         1672     1672           
  Misses       3408     3408           
  Partials      719      719           
Flag Coverage Δ
collector-unit-tests 28.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Molter73 Molter73 force-pushed the mauro/fact/adjust-workflows branch 3 times, most recently from 4f23f1c to 51cc1d8 Compare August 1, 2025 10:14
@Molter73 Molter73 force-pushed the mauro/fact/adjust-workflows branch from 51cc1d8 to 9d83327 Compare August 1, 2025 10:17
@Molter73 Molter73 changed the title Adjust the setup-vm-creds action to be used from other repos Make ansible playbooks and CI actions compatible with stackrox/fact Aug 1, 2025
@Molter73 Molter73 marked this pull request as ready for review August 1, 2025 16:28
@Molter73 Molter73 requested a review from a team as a code owner August 1, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants