-
Notifications
You must be signed in to change notification settings - Fork 159
ROX-30577: Add process baseline auto locking to cluster config #16669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ROX-30577: Add process baseline auto locking to cluster config #16669
Conversation
Skipping CI for Draft Pull Request. |
Images are ready for the commit at eda74d4. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16669 +/- ##
===========================================
+ Coverage 47.97% 48.62% +0.65%
===========================================
Files 768 2664 +1896
Lines 79004 199398 +120394
===========================================
+ Hits 37903 96963 +59060
- Misses 37648 94835 +57187
- Partials 3453 7600 +4147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@JoukoVirtanen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Adds auto locking to the cluster protobuf. Also makes it so that the cluster configuration is used to control auto locking. Thus it will be possible to control process baseline auto locking at the cluster level. The feature flag is still in place and in order to enable process baseline auto locking for a cluster the feature flag needs to be enabled and it needs to be enabled for the cluster via the cluster config.
After this change it will not be possible to control this new cluster field via helm or operator. That will be done in other PRs.
The PR to control process baseline auto-locking via helm can be found here #16462
This PR replaces #16427
User-facing documentation
Testing and quality
Automated testing
How I validated my change
et the following environment variables
Deployed ACS.
Created a pod that could be used to run some processes and entered it.
Logged into the UI and checked "Risk".
The process baseline was still unlocked after more than five minutes.
Ran the following script to enable process baseline auto locking for the cluster
Created another pod, entered it, and ran a command
Initially the process baseline is unlocked.
After a little more than five minutes the baseline is locked.
Running a new process results in a violation