Skip to content

Conversation

@Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Jul 17, 2025

Description

I initially had this fix in #6201 but decided to move it a separate PR just in case.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc added this to the 3.1.0.0.14 milestone Jul 17, 2025
@Jiloc Jiloc self-assigned this Jul 17, 2025
@Jiloc Jiloc requested review from a team July 17, 2025 09:38
@Jiloc Jiloc moved this to Status: In Review in Stacks Core Eng Jul 17, 2025
jferrant
jferrant previously approved these changes Jul 17, 2025
@Jiloc Jiloc modified the milestones: 3.2.0.0.0, 3.2.0.0.1 Jul 24, 2025
@Jiloc Jiloc moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 24, 2025
@Jiloc Jiloc requested review from jferrant and wileyj July 25, 2025 10:14
@Jiloc Jiloc moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Jul 25, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Aug 1, 2025
@Jiloc Jiloc added this pull request to the merge queue Aug 1, 2025
Merged via the queue into stacks-network:develop with commit c03c4f7 Aug 1, 2025
1 of 2 checks passed
@Jiloc Jiloc deleted the fix/v2-stackerdb-metrics-identifier branch August 1, 2025 15:12
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Aug 1, 2025
@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.95%. Comparing base (6168284) to head (b979ca6).
⚠️ Report is 65 commits behind head on develop.

❌ Your project status has failed because the head coverage (75.95%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (6168284) and HEAD (b979ca6). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (6168284) HEAD (b979ca6)
133 119
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6296      +/-   ##
===========================================
- Coverage    81.45%   75.95%   -5.50%     
===========================================
  Files          540      540              
  Lines       347695   347695              
===========================================
- Hits        283225   264108   -19117     
- Misses       64470    83587   +19117     
Files with missing lines Coverage Δ
stackslib/src/net/api/liststackerdbreplicas.rs 90.00% <100.00%> (ø)

... and 225 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6168284...b979ca6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Aug 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Aug 9, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants