-
Notifications
You must be signed in to change notification settings - Fork 725
Additional SIP-031 tests #6316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional SIP-031 tests #6316
Conversation
hstove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
jcnelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a testing protocol I'm familiar with. Do these all run in CI?
|
This looks good and idiomatic for fast-check. 👍 I also left some comments. One possible improvement would be to move toward a command/invariant model, as in #6321. That way, the sequence of steps in the tests wouldn’t be hardcoded or repeated. But this shouldn’t be a blocker. If and when this gets merged, I can follow up with a PR that introduces that structure, living alongside the existing tests. |
These are using the unit test framework from Clarinet. Yes, they should run in CI with the core-contract-tests. |
…dditional SIP-031 tests stacks-network#6316)
moodmosaic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (54.34%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6316 +/- ##
============================================
- Coverage 81.45% 54.34% -27.12%
============================================
Files 540 541 +1
Lines 347695 347771 +76
============================================
- Hits 283225 189000 -94225
- Misses 64470 158771 +94301 see 421 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds some more unit tests, some random tests, and some fast-check tests.