Skip to content

Conversation

@obycode
Copy link
Contributor

@obycode obycode commented Jul 21, 2025

This PR adds some more unit tests, some random tests, and some fast-check tests.

hstove
hstove previously approved these changes Jul 24, 2025
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wileyj wileyj added this to the 3.2.0.0.1 milestone Jul 25, 2025
@wileyj wileyj moved this to Status: In Review in Stacks Core Eng Jul 25, 2025
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a testing protocol I'm familiar with. Do these all run in CI?

@moodmosaic
Copy link
Contributor

This looks good and idiomatic for fast-check. 👍 I also left some comments.

One possible improvement would be to move toward a command/invariant model, as in #6321. That way, the sequence of steps in the tests wouldn’t be hardcoded or repeated. But this shouldn’t be a blocker. If and when this gets merged, I can follow up with a PR that introduces that structure, living alongside the existing tests.

@obycode
Copy link
Contributor Author

obycode commented Jul 27, 2025

This isn't a testing protocol I'm familiar with. Do these all run in CI?

These are using the unit test framework from Clarinet. Yes, they should run in CI with the core-contract-tests.

moodmosaic added a commit to moodmosaic/stacks-core that referenced this pull request Jul 29, 2025
Copy link
Contributor

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obycode obycode added this pull request to the merge queue Jul 29, 2025
Merged via the queue into stacks-network:develop with commit 1b00198 Jul 29, 2025
1 check passed
@obycode obycode deleted the test/sip-031 branch July 29, 2025 20:25
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.34%. Comparing base (6168284) to head (807527c).
⚠️ Report is 45 commits behind head on develop.

❌ Your project status has failed because the head coverage (54.34%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (6168284) and HEAD (807527c). Click for more details.

HEAD has 71 uploads less than BASE
Flag BASE (6168284) HEAD (807527c)
133 62
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6316       +/-   ##
============================================
- Coverage    81.45%   54.34%   -27.12%     
============================================
  Files          540      541        +1     
  Lines       347695   347771       +76     
============================================
- Hits        283225   189000    -94225     
- Misses       64470   158771    +94301     

see 421 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6168284...807527c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Aug 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants