feat: use longest common prefix for determining tx replay set #6353
+398
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdefelici
reviewed
Aug 7, 2025
jferrant
reviewed
Aug 7, 2025
jferrant
reviewed
Aug 7, 2025
| /// Find the longest common prefix of replay sets that has majority support. | ||
| /// This implements the longest common prefix (LCP) strategy where if one signer's replay set | ||
| /// is [A,B,C] and another is [A,B], we should use [A,B] as the replay set. | ||
| /// Order matters for transaction replay - [A,B] and [B,A] have no common prefix. |
There was a problem hiding this comment.
Hahaha this looks like a leetcode question XD
There was a problem hiding this comment.
Haha I know, and it makes me feel fancy, but it's really much simpler than it sounds 😆
jferrant
previously approved these changes
Aug 7, 2025
fdefelici
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the global state machine evaluator to use a longest common prefix algorithm to determine the global transaction replay set after a fork.
For example, if one replay set is [A,B,C] with 50% weight, and another is [A,B] with 30% weight, then we will use [A,B] as the global replay set.
There is code for ensuring we end up with a deterministic global replay set by doing a comparison of signer weight, and then length, and then via txid comparisons.