Skip to content

Conversation

@Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Aug 7, 2025

Description

While looking at the clippy warnings that came out with 1.89 I realized config-docs-generator also had some clippy warnings that needed to be fixed since 1.88.

  • Fixed uninlined-format-args and collapsible-if clippy warnings.
  • Remove export RUSTFLAGS="${RUSTFLAGS:-} -A mismatched-lifetime-syntaxes" now that those warnings have been fixed in develop.

All tests still pass. Also the CI step that uses this binary still succesfully creates the documentation https://github.com/stacks-network/stacks-core/actions/runs/16816574654/job/47635550986?pr=6359

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc self-assigned this Aug 7, 2025
@Jiloc Jiloc changed the base branch from master to develop August 7, 2025 21:30
@Jiloc Jiloc changed the title fix: config-docs-generator uninlined-format-args clippy warning fix: config-docs-generator uninlined-format-args and collapsible-if clippy warnings Aug 8, 2025
@Jiloc Jiloc marked this pull request as ready for review August 8, 2025 13:21
@Jiloc Jiloc requested review from a team August 8, 2025 13:21
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aldur aldur added this to the 3.2.0.0.1 milestone Aug 11, 2025
@aldur aldur moved this to Status: In Review in Stacks Core Eng Aug 11, 2025
@aldur aldur added this pull request to the merge queue Aug 11, 2025
Merged via the queue into stacks-network:develop with commit 8caa5e4 Aug 11, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Aug 11, 2025
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 84.48276% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.55%. Comparing base (c21aea7) to head (2578c7d).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ib/tools/config-docs-generator/src/extract_docs.rs 80.00% 8 Missing ⚠️
...ols/config-docs-generator/src/generate_markdown.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6359      +/-   ##
===========================================
+ Coverage    75.81%   79.55%   +3.73%     
===========================================
  Files          552      552              
  Lines       351807   351788      -19     
===========================================
+ Hits        266724   279862   +13138     
+ Misses       85083    71926   -13157     
Files with missing lines Coverage Δ
...ols/config-docs-generator/src/generate_markdown.rs 98.49% <94.44%> (+7.46%) ⬆️
...ib/tools/config-docs-generator/src/extract_docs.rs 95.57% <80.00%> (+10.04%) ⬆️

... and 248 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21aea7...2578c7d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants