-
Notifications
You must be signed in to change notification settings - Fork 724
fix: config-docs-generator uninlined-format-args and collapsible-if clippy warnings
#6359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config-docs-generator uninlined-format-args and collapsible-if clippy warnings
#6359
Conversation
uninlined-format-args clippy warninguninlined-format-args and collapsible-if clippy warnings
obycode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8caa5e4
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6359 +/- ##
===========================================
+ Coverage 75.81% 79.55% +3.73%
===========================================
Files 552 552
Lines 351807 351788 -19
===========================================
+ Hits 266724 279862 +13138
+ Misses 85083 71926 -13157
... and 248 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
While looking at the clippy warnings that came out with 1.89 I realized
config-docs-generatoralso had some clippy warnings that needed to be fixed since 1.88.uninlined-format-argsandcollapsible-ifclippy warnings.export RUSTFLAGS="${RUSTFLAGS:-} -A mismatched-lifetime-syntaxes"now that those warnings have been fixed in develop.All tests still pass. Also the CI step that uses this binary still succesfully creates the documentation https://github.com/stacks-network/stacks-core/actions/runs/16816574654/job/47635550986?pr=6359
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml