Skip to content

Conversation

@fdefelici
Copy link
Contributor

Description

This PR fixes additional occurrences of clippy::mismatched-lifetime-syntaxes that appeared after updating to Rust 1.89.0.

These warnings were detected when running cargo check --tests locally but were not caught by CI during PR #6356.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@fdefelici fdefelici self-assigned this Aug 8, 2025
@fdefelici fdefelici requested review from a team August 8, 2025 12:54
@fdefelici fdefelici added this to the 3.2.0.0.1 milestone Aug 8, 2025
@fdefelici fdefelici moved this to Status: In Review in Stacks Core Eng Aug 8, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Aug 11, 2025
@Jiloc Jiloc added this pull request to the merge queue Aug 11, 2025
Merged via the queue into stacks-network:develop with commit a9e2828 Aug 11, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Aug 11, 2025
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.86%. Comparing base (c21aea7) to head (0c5720d).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/net/tests/download/epoch2x.rs 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (74.86%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6360      +/-   ##
===========================================
- Coverage    75.81%   74.86%   -0.95%     
===========================================
  Files          552      552              
  Lines       351807   351816       +9     
===========================================
- Hits        266724   263399    -3325     
- Misses       85083    88417    +3334     
Files with missing lines Coverage Δ
stackslib/src/chainstate/stacks/index/marf.rs 82.61% <100.00%> (ø)
stackslib/src/net/tests/convergence.rs 84.27% <100.00%> (-8.99%) ⬇️
stackslib/src/net/tests/download/epoch2x.rs 10.78% <0.00%> (+10.78%) ⬆️

... and 320 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21aea7...0c5720d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants