-
Notifications
You must be signed in to change notification settings - Fork 700
Added /v3/tenures/blocks/{consensus_hash} endpoint #6431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added /v3/tenures/blocks/{consensus_hash} endpoint #6431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the update to the openapi spec
Note: i rollbacked the BurnHeaderHash usage as it serializes to an array of numbers by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just a couple nits and then I'll approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for the tests to wrap up before approving, but LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just a doc typo needs to be fixed
e6487f6
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (71.97%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6431 +/- ##
===========================================
- Coverage 78.71% 71.97% -6.75%
===========================================
Files 555 557 +2
Lines 344902 345182 +280
===========================================
- Hits 271479 248432 -23047
- Misses 73423 96750 +23327
... and 258 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This patch adds the first (of 3) new endpoints allowing getting the list of stacks blocks given a burnblock (here by consensus hash, next endpoints will cover height and block hash).
It is part (along the simulation block api #6346) of the features required by wormhole.