Skip to content

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Sep 1, 2025

Description

This patch adds the first (of 3) new endpoints allowing getting the list of stacks blocks given a burnblock (here by consensus hash, next endpoints will cover height and block hash).

It is part (along the simulation block api #6346) of the features required by wormhole.

@rdeioris rdeioris requested review from a team as code owners September 1, 2025 13:31
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the update to the openapi spec

@rdeioris rdeioris requested review from jcnelson and Jiloc September 3, 2025 16:37
@rdeioris
Copy link
Contributor Author

rdeioris commented Sep 3, 2025

Note: i rollbacked the BurnHeaderHash usage as it serializes to an array of numbers by default.

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a couple nits and then I'll approve

@rdeioris rdeioris requested a review from jcnelson September 4, 2025 05:35
@rdeioris rdeioris requested a review from Jiloc September 4, 2025 11:57
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for the tests to wrap up before approving, but LGTM!

@rdeioris rdeioris requested a review from Jiloc September 4, 2025 14:30
Jiloc
Jiloc previously approved these changes Sep 4, 2025
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a doc typo needs to be fixed

@rdeioris rdeioris requested a review from Jiloc September 5, 2025 15:49
@rdeioris rdeioris enabled auto-merge September 9, 2025 05:29
@rdeioris rdeioris added this pull request to the merge queue Sep 9, 2025
Merged via the queue into stacks-network:develop with commit e6487f6 Sep 9, 2025
288 of 294 checks passed
@rdeioris rdeioris deleted the feat/tenureblocks_endpoint branch September 9, 2025 06:28
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 88.21429% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.97%. Comparing base (ab6459b) to head (8d4218c).
⚠️ Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/net/api/gettenureblocks.rs 86.01% 27 Missing ⚠️
stackslib/src/net/api/tests/gettenureblocks.rs 92.59% 6 Missing ⚠️

❌ Your project status has failed because the head coverage (71.97%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (ab6459b) and HEAD (8d4218c). Click for more details.

HEAD has 37 uploads less than BASE
Flag BASE (ab6459b) HEAD (8d4218c)
109 72
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6431      +/-   ##
===========================================
- Coverage    78.71%   71.97%   -6.75%     
===========================================
  Files          555      557       +2     
  Lines       344902   345182     +280     
===========================================
- Hits        271479   248432   -23047     
- Misses       73423    96750   +23327     
Files with missing lines Coverage Δ
stackslib/src/chainstate/stacks/db/mod.rs 80.03% <100.00%> (-5.14%) ⬇️
stackslib/src/net/api/mod.rs 92.53% <100.00%> (+0.11%) ⬆️
stackslib/src/net/api/tests/mod.rs 96.72% <ø> (-1.10%) ⬇️
stackslib/src/net/api/tests/gettenureblocks.rs 92.59% <92.59%> (ø)
stackslib/src/net/api/gettenureblocks.rs 86.01% <86.01%> (ø)

... and 258 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6459b...8d4218c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants