-
Notifications
You must be signed in to change notification settings - Fork 714
feat: add support for secp256r1 and replace libsecp256k1 #6581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why are we dropping |
Add tests for `secp256k1-verify` and `secp256k1-recover?` while adding tests for this new function.
The thought was that since we're pulling in the RustCrypto crate for secp256r1, we may as well also replace the k256 crate as well with this Rust-native solution that seems to be well-vetted and audited as well. libsecp256k1 is a wrapped C library. |
This removes the need for trying the recovery bytes to find the right one.
…eserialize` The signature will be checked after deserialization. Checking it here will cause a deserialization failure when what we actually want is a signature validation failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have a few codec bugs that need to be fixed before merging.
...ts/snapshots/blockstack_lib__chainstate__tests__consensus__successfully_deploy_and_call.snap
Show resolved
Hide resolved
d622c3d
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (52.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6581 +/- ##
============================================
- Coverage 79.82% 52.59% -27.23%
============================================
Files 571 573 +2
Lines 351696 352704 +1008
============================================
- Hits 280724 185497 -95227
- Misses 70972 167207 +96235
... and 414 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Implementing #6554.