Chore/merge develop to aac client breaking #6596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into aac-client-breaking
This just adds the basic support for the syntax and some setup for the full implementation.
That infrastructure is not setup for handling PoX state, and the stacking tracking in the asset maps is not setup yet any way.
Testing still needed.
We decided to remove this because it doesn't really make sense.
… into chore/limit-staging-blocks-db-access
Signed-off-by: Jacinta Ferrant <[email protected]>
Jiloc
previously approved these changes
Oct 14, 2025
test: add vm_error to snapshot
fdefelici
previously approved these changes
Oct 14, 2025
…ing-blocks-db-access Make access to Nakamoto staging blocks restricted to one single pub fn
…ersions Signed-off-by: Jacinta Ferrant <[email protected]>
… invalid block Signed-off-by: Jacinta Ferrant <[email protected]>
…e-contract-consensus-test
…sus-test-api feat: add macros for contract consensus tests
Signed-off-by: Jacinta Ferrant <[email protected]>
…-invalid-pox-call-invalid-block Remove unreachable error type and use existing Expect error to ensure invalid block
…llformed-tenure-fns Make is_wellformed_tenure_*_block return Error and remove custom conversions
… into chore/merge-develop-to-aac-client-breaking
…contract-consensus-test feat: contract consensus test dynamic nonce update
… into chore/merge-develop-to-aac-client-breaking
federico-stacks
approved these changes
Oct 17, 2025
Jiloc
approved these changes
Oct 17, 2025
Comment on lines
+486
to
+494
| // contract post-conditions | ||
| ExpectedListOfAllowances(String, i32), | ||
| AllowanceExprNotAllowed, | ||
| ExpectedAllowanceExpr(String), | ||
| WithAllAllowanceNotAllowed, | ||
| WithAllAllowanceNotAlone, | ||
| WithNftExpectedListOfIdentifiers, | ||
| MaxIdentifierLengthExceeded(u32, u32), | ||
| TooManyAllowances(usize, usize), |
There was a problem hiding this comment.
We'll need to document these too :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.