feat: enforce ordering of allowance check #6602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
previously approved these changes
Oct 14, 2025
jcnelson
reviewed
Oct 14, 2025
jcnelson
reviewed
Oct 14, 2025
jcnelson
reviewed
Oct 14, 2025
jcnelson
reviewed
Oct 14, 2025
jcnelson
reviewed
Oct 14, 2025
jcnelson
previously approved these changes
Oct 14, 2025
|
It took me an embarrassing amount of time to figure out what was happening in this PR. I was confused, got a tea, reread and went "oh....Caffeine has made it clear." LGTM! |
jferrant
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jcnelson pointed out that the SIP states that the allowances are checked in declaration order, but my original implementation was only preserving order within each kind of asset movement, not overall. This fixes that.