Remove user confirmation from MiproV2 #8552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomeHirata
commented
Jul 20, 2025
| @@ -112,7 +109,7 @@ def compile( | |||
| view_data_batch_size: int = 10, | |||
| tip_aware_proposer: bool = True, | |||
| fewshot_aware_proposer: bool = True, | |||
| requires_permission_to_run: bool = True, | |||
| requires_permission_to_run: bool = True, # deprecated | |||
There was a problem hiding this comment.
Unfortunately, removing this argument will result in breaking the users' code that passes requires_permission_to_run=False. Do we think this breaking change is acceptable in DSPy 3? We could add **kwargs instead, but it would lead to a loss of undefined argument detection.
There was a problem hiding this comment.
We can introduce the wildcard kwargs and move the deprecated args there, and print a clear warning that it's deprecated.
There was a problem hiding this comment.
Yeah, that's feasible. But I would be cautious about introducing **kwarg as users won't be able to know when they mistakenly pass an undefined argument (or typo). What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User confirmation only exists for MiproV2. This PR removes the feature for consistency.