This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Update linter config#4
Closed
heymatthew wants to merge 2 commits into
Closed
Conversation
Pull Request Test Coverage Report for Build 18210552343Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 18210552343Details
💛 - Coveralls |
Author
|
This is not needed as upstream is running golangci-lint 1.62.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOOP: github actions version of golangci-lint can use .goalngci.yml
We've gone from a v1 to a v2 and this needed migration. I've put back timeout and a single comment around overflow, the other comments seemed redundant.
This looks like a straight fork of h3 so I don't think it'll use our internal lint settings. I think we can close this PR off, LMK what you think in the comments. 👀