Go SDK tests #1007
Merged
Go SDK tests #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delaneyj
reviewed
Jul 15, 2025
Collaborator
delaneyj
left a comment
delaneyj
left a comment
There was a problem hiding this comment.
I think we can remove the Docker stuff completely now
delaneyj
approved these changes
Jul 15, 2025
Collaborator
delaneyj
left a comment
delaneyj
left a comment
There was a problem hiding this comment.
Talking in the Discords this is a better approach than my scorched earth version
This was referenced Jul 15, 2025
Closed
Closed
Collaborator
|
Merged, thanks all!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take just
sdk/testsfromrepo-per-sdkbranch, plus @gazpachoking 's fixes.The idea is to make these Go tests available on their own, so that SDKs can rely on them as they move into their own repos.
To test locally, you can
1). Launch your test app, for example on
http://localhost:80002). In this repo:
cd sdk/tests3).
go run ./cmd/datastar-sdk-tests -server http://localhost:8000For reference, this is how this can be used during CI on each SDK's repo starfederation/datastar-ruby#1