Replace string with a structured error in CONTRACT_ERROR & TRANSACTION_EXECUTION_ERROR #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielElp
commented
Sep 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArielElp)
ArielElp
force-pushed
the
structured_error_trace
branch
from
03664bc
to
6feb690
Compare
ArielElp
commented
Sep 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rpc <= 0.7.0, returned errors are strings encoding execution traces (used to be a lot of redundancy, e.g. scary "got an error while executing a hint" repeating a bunch of times, this should already be cleaner in starknet v0.13.2). Now that we have more structure (also see stack_trace.rs) in the blockifier, we can return the structured data and let sdks/wallets process it rather than rely on string manipulations.
This change is