Added loop feature for markers + AB prefill #6510
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GammelSami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a “Loop” action next to a marker’s timestamp range. It is only shown when the marker has an end time and AB loop controls are enabled.
This should cover the different user behaviors described in #6050 without adding new settings. The important part is that the feature exists now. If the trigger or placement should be handled differently, it can be changed later.
Also I noticed that there was no way to save AB timestamps. So the marker start/end input fields are now prefilled with the currently set AB timestamps (if present), instead of simply taking the playhead start time. This allows users to easily save their AB loop, while other users can still use the clock button in this case.