Skip to content

Conversation

@cacheflush
Copy link

This PR adds some new configuration options for sprite generation:

  • Minimum sprites
  • Resolution of sprites
  • time between two sprites

I've added the corresponding options to the system settings panel.

Sprites are now generated in a single row, to make the generation more manageable, especially for prime numbers.
I couldn't find any drawbacks to this approach since the phash generation is independent from sprite generation.

I've also added some locales using a LLM and as far as I can tell the translation is accurate.

The added documentation contains some more detailed info about the new settings.

This is related to #4023

@DogmaDragon
Copy link
Collaborator

Translations are exclusively handled via Codeberg Translate.

@DogmaDragon
Copy link
Collaborator

Scene Tagger has a button to show raw sprite which inline generation probably breaks.
image

@cacheflush
Copy link
Author

Translations are exclusively handled via Codeberg Translate.

If I understand this correctly, I still have to add the values to the en-GB.json manually, right?
If so I will just remove the rest from this PR.

Scene Tagger has a button to show raw sprite which inline generation probably breaks.

Very good catch, I will fix this.

@DogmaDragon
Copy link
Collaborator

If I understand this correctly, I still have to add the values to the en-GB.json manually, right?

Yes.

@cacheflush
Copy link
Author

I removed the unwanted locales and provided a fix to the mentioned tagger view problem.
The sprites are now generated in a dynamically sized grid.
The added functionality that comes with this PR remains untouched, while you can easily view the raw sprite in the tagger again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants