[6.x] Fix modal mounting #13284
Merged
[6.x] Fix modal mounting #13284
+22
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. the escBinding doesnt need a next tick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #13202, I noticed some modals didn't work. It complained about the portal target not existing.
Not exactly sure why it works for some modals and not others. Maybe it was standalone modal vs confirmation modals?
e.g. the column customizer was broken but table row actions with confirmation modals were fine.
This PR fixes that by setting the
mountedvalue to true on the next tick.The visible still needs to be on the next tick so that we get the nice transition. If they were on the same tick, the modal would just immediately pop in.
I also noticed tabs were used in here so I switched to spaces.