build(nitro-protocol): upgrade Solidity version#1839
Open
maxpushka wants to merge 5 commits intostatechannels:mainfrom
Open
build(nitro-protocol): upgrade Solidity version#1839maxpushka wants to merge 5 commits intostatechannels:mainfrom
maxpushka wants to merge 5 commits intostatechannels:mainfrom
Conversation
✅ Deploy Preview for nitro-payment-demo canceled.
|
👷 Deploy Preview for nitrodocs processing.
|
Contributor
|
Updating compiler target is OK, and I'm also fine with including the Q: should all compiler pragmas include the Problem: after running the tests, this seems to have broken some dependencies. First guess at root cause is that the simulatedbackend service used in the tests does not implement PUSH0, which was added in 0.8.20. See: https://medium.com/coinmonks/push0-opcode-a-significant-update-in-the-latest-solidity-version-0-8-20-ea028668028a First guess at a fix would be to update the go-ethereum dependencies that the SimulatedBackend uses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Solidity version
Body
^) insolidity pragmaRestricting major compiler version allow contract inheritance to compile with higher solidity versions, loosely coupling the versions. Hence, the risk of introducing breaking changes into the project is lowered. Major version increments (as per semantic versioning) usually include changes that are not backwards-compatible. Using the caret symbol helps maintain stability in the project.
How Has This Been Tested?
Tests were run with
yarn testCode quality