feat_: introduce ethclient #6
Open
+7,698
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipicar
force-pushed
the
feat/balance-fetcher-erc20
branch
from
46062d7 to
85ceaad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
===========================================
- Coverage 87.28% 51.20% -36.09%
===========================================
Files 5 16 +11
Lines 236 1125 +889
===========================================
+ Hits 206 576 +370
- Misses 26 527 +501
- Partials 4 22 +18
🚀 New features to boost your workflow:
|
dlipicar
force-pushed
the
feat/ethclient
branch
3 times, most recently
from
e83cde8 to
a7ee8ac
Compare
vkjr
reviewed
Jul 28, 2025
| } | ||
|
|
||
| // Real block JSON data | ||
| blockJSON := `{ |
There was a problem hiding this comment.
What do you think about putting this in a separate json file and loading it dynamically?
vkjr
reviewed
Jul 28, 2025
| "github.com/ethereum/go-ethereum/common/hexutil" | ||
| "github.com/ethereum/go-ethereum/rpc" | ||
| ) | ||
|
|
There was a problem hiding this comment.
It would be nice to have explanatory comments on these methods as we have in all other files
|
Looks great! 🎉 |
vkjr
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce types and a convenience client to interact with the standard Ethereum JSON-RPC interface.
go-ethereum's types contain some additional logic (calculate hash based on the contents of a Block/Transaction, for example) which makes them inconvenient to use across different L1s and L2s. This implementation consumes all (and only) information provided in the JSON-RPC responses with no extra assumptions.