-
Notifications
You must be signed in to change notification settings - Fork 32
EIP 7919: Pureth Meta #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cc @advaita-saha for making sure that the db can know the new stored receipts and also test it out properly what tests do i need to add ? You had mentioned we might need tests in test_eth_types_serialization too with a version of |
| logs* : seq[Log] | ||
| eip7807ReceiptType*: Eip7807ReceiptType | ||
| authorities* : seq[Address] | ||
| txGasUsed* : uint64 # Gas used by THIS transaction only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is txGasUsed required from spec?
If yes please mentioned spec link in comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yups
Here's the above-mentioned Link
https://github.com/ethereum/EIPs/blob/676604927b316a44195008e632778d4ca1101deb/EIPS/eip-6466.md?plain=1#L138
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention it in the code as a comment
|
CI won't run here until the |
|
Addressed conflict! |
This Pr introduces all the types required + the helper functions for the same to implement
EIP 7919- Pureth Meta
The files inside eth/ssz have the type definitions and the recast functions to be per the
The open question was
The answer that came up was to change stored receipts to make room for the new fields and pass them on to the
makereceiptsand have them produce the new stored receipt variant with eip7807 and then recast them into seq[ssz_receipts] and then calc the rootSo we need to save the new variant in the db too, as the stored receipt is what is present in the db and do tests to make sure its correct