async updateBase#4174
Draft
advaita-saha wants to merge 5 commits into
Draft
Conversation
… every 16 ancestors during the cleanup loop — so a full 256-block batch gets ~17 yield points instead of 0. - Reordered so c.base / c.baseTxFrame pointer updates happen before the cleanup burst, with oldFrontier = base.parent captured first. If a shutdown cancels us mid-cleanup, ForkedChain invariants stay coherent. - Split wall-clock into persistMs + cleanupMs aggregated over the batch and surfaced in the existing "Finalized blocks persisted" log — the cheapest possible instrumentation to tell you at a glance whether future stalls are disk or cleanup. - processUpdateBase now awaits the async updateBase.
Contributor
|
@advaita-saha I find all the comments in the PR to be overly verbose. I would suggest removing most of them, just keeping the most necessary. |
bhartnett
reviewed
Apr 24, 2026
Contributor
Author
Yes the comments are there mostly for me so intentionally verbose, as I am working on multiple branches with different things. |
bhartnett
reviewed
Apr 24, 2026
Contributor
Author
|
Deploying branch to my home validator nodes ( hoodi ) for analysing improvement |
Contributor
Author
|
Noticed minimal to no improvement in attestation perfomance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateBase is now async, yielding once after db.persist() and once every 16 ancestors during the cleanup loop — so a full 256-block batch gets
~17 yield points instead of 0.