Updated client identification code to NE#4447
Open
rolfyone wants to merge 2 commits into
Open
Conversation
Contributor
|
Fine merging this if the corresponding spec PR goes in. |
Member
|
is it a problem that it uses the same for both? ie there's only one nimbus at the end, it just happens to have two components |
The code in use (NB) was for nimbus CL, and because they're position independent this was basically a collision to have Nimbus EL using NB as well. I've also raised an execution PR to reserve `NE` for Nimbus EL. reference PR ethereum/execution-apis#848
tersec
force-pushed
the
client-code-execution
branch
from
July 12, 2026 13:18
742fdfe to
15dd5a5
Compare
Author
Conceptually it's kinda weird because it appears in both sides of the stack... From the execution api it's defined CL's and EL's and theres a clear split except for Nimbus. I'm not sure how we'd differentiate what NB is acting as, it basically breaks the way we've specified the codes if there's no difference, it'd arguably look like 2 CL's building a full block... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in use (NB) was for nimbus CL, and because they're position independent this was basically a collision to have Nimbus EL using NB as well.
I've also raised an execution PR to reserve
NEfor Nimbus EL.reference PR ethereum/execution-apis#848