Skip to content

Conversation

@agnxsh
Copy link
Contributor

@agnxsh agnxsh commented Jan 12, 2026

@agnxsh agnxsh changed the title Gbv3 add: engine_getBlobsV3 helpers for cell level dissemination Jan 12, 2026
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Unit Test Results

       12 files  ±0    2 440 suites  ±0   50m 47s ⏱️ + 1m 7s
12 693 tests ±0  12 128 ✔️ ±0  565 💤 ±0  0 ±0 
63 840 runs  ±0  63 112 ✔️ ±0  728 💤 ±0  0 ±0 

Results for commit 23a32ab. ± Comparison against base commit a4e93d1.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Jan 12, 2026

sidecars

proc assemble_partial_data_column_sidecars*(
signed_beacon_block: fulu.SignedBeaconBlock | gloas.SignedBeaconBlock,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to actually work/do anything for Gloas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't, it was added anticipating, this feature would roll over in gloas


proc sendGetBlobsV3*(
m: ElManager,
blck: fulu.SignedBeaconBlock | gloas.SignedBeaconBlock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually handle gloas in any useful way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't, it was added anticipating, this feature would roll over in gloas

@tersec tersec merged commit 18c6d85 into unstable Jan 15, 2026
11 checks passed
@tersec tersec deleted the gbv3 branch January 15, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants