-
Notifications
You must be signed in to change notification settings - Fork 303
add: engine_getBlobsV3 helpers for cell level dissemination
#7847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
engine_getBlobsV3 helpers for cell level dissemination
| sidecars | ||
|
|
||
| proc assemble_partial_data_column_sidecars*( | ||
| signed_beacon_block: fulu.SignedBeaconBlock | gloas.SignedBeaconBlock, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to actually work/do anything for Gloas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't, it was added anticipating, this feature would roll over in gloas
beacon_chain/el/el_manager.nim
Outdated
|
|
||
| proc sendGetBlobsV3*( | ||
| m: ElManager, | ||
| blck: fulu.SignedBeaconBlock | gloas.SignedBeaconBlock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually handle gloas in any useful way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't, it was added anticipating, this feature would roll over in gloas
ethereum/execution-apis#674
ethereum/consensus-specs#4558