Issues with the in-chat payment request #19599
Merged
+929
−321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
a team and
glitchminer
and removed request for
a team
saledjenic
requested review from
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (44)
|
saledjenic
force-pushed
the
fix/payment-request
branch
from
6b9eea6 to
f623142
Compare
saledjenic
force-pushed
the
fix/payment-request
branch
from
f623142 to
f05b508
Compare
micieslak
reviewed
Dec 17, 2025
| /** Token groups for chain, loaded on demand, without balances **/ | ||
| required property var tokenGroupsForChainModel | ||
| /** token groups that match the search keyword **/ | ||
| property var searchResultModel |
Member
There was a problem hiding this comment.
- It would be nice to have some specification what roles/types are expected for that model.
- If there are some extra requirements (something not present in QAbstractModelItem by default) it should be also specified and clarified
Member
There was a problem hiding this comment.
It would be nice to have also some top-level description what is this adaptor doing.
saledjenic
force-pushed
the
fix/payment-request
branch
from
f05b508 to
759c886
Compare
friofry
approved these changes
Dec 22, 2025
| } | ||
|
|
||
| function onIsLoadingMoreChanged() { | ||
| root.fullOutputModel.isLoadingMore = root.tokenGroupsForChainModel.isLoadingMore |
Contributor
There was a problem hiding this comment.
it's root.fullOutputModel and d.fullOutputModel few lines above. Which is correct?
|
|
||
|
|
||
| // output model - lazy loaded full model | ||
| readonly property SortFilterProxyModel fullOutputModel: SortFilterProxyModel { |
Contributor
There was a problem hiding this comment.
There are ~50 identical lines in fullOutputModel and outputSearchResultModel.
Could you extract the common code in a groups model, and make sourceModel and other callbacks dynamic?
readonly property GroupsModel fullModel: GroupsModel {
objectName: "PaymentRequestAdaptor_fullModel"
sourceTokenModel: root.tokenGroupsForChainModel
flatNetworksModel: root.flatNetworksModel
selectedNetworkChainId: root.selectedNetworkChainId
function fetchMore() {
root.tokenGroupsForChainModel.fetchMore()
}
}
readonly property GroupsModel searchModel: GroupsModel {
objectName: "PaymentRequestAdaptor_searchModel"
sourceTokenModel: root.searchResultModel
flatNetworksModel: root.flatNetworksModel
selectedNetworkChainId: root.selectedNetworkChainId
function search(keyword) {
root.searchResultModel.search(keyword)
}
function fetchMore() {
root.searchResultModel.fetchMore()
}
}
Or make a separate qml component that handles everything under the hood:
readonly property var outputModel: !!d.searchKeyword ? d.outputSearchResultModel : d.fullOutputModel
->
readonly property var outputModel: d.groupModel
| ## | ||
| ## Itterates over all tokens for the given chain and returns the first token | ||
| ## that matches the symbol or name (cause some tokens have different symbols for EVM/BSC chains), case insensitive. | ||
| proc getTokenBySymbolOnChain*(self: Service, symbol: string, chainId: int): TokenItem = |
Contributor
Author
There was a problem hiding this comment.
Unfortunatelly we cannot (unless we don't care about backward compatibillity). If we delete it we will break backward compatibility for an already received payment requests in the past.
saledjenic
force-pushed
the
fix/payment-request
branch
from
759c886 to
991f653
Compare
saledjenic
force-pushed
the
fix/payment-request
branch
from
991f653 to
38ec7f1
Compare
Khushboo-dev-cpp
approved these changes
Dec 23, 2025
Contributor
Khushboo-dev-cpp
left a comment
Khushboo-dev-cpp
left a comment
There was a problem hiding this comment.
LGTM :)
Also tested on macOS and works well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding
status-goPR:Fixes #19518
Changes are backward compatible: