Chore: browser popup refactoring #19613
Open
+649
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkjr
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (25)
|
chore: step 2, adaptor added chore: step 3.. partial chore: TransactionDelegate simplified with adaptor chore: added objectproxymodel for transactions delegate chore: small fixes
vkjr
force-pushed
the
chore/browser-popup-refactoring
branch
from
37d6d7c to
330dd96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19498
Description
Refactoring made.
Changes:
TODO
BrowserWalletMenuinstantiation in BrowserLayout.qml, pass properties needed insideonOpenWalletMenuin BrowserLayout.qml to an adaptor layerui/app/AppLayouts/stores/Browserui/app/AppLayouts/stores/RootStore.qml