android: create and sign separate bundle ID for PRs #19614
+226
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (183)
|
siddarthkay
force-pushed
the
fix-android-signing
branch
14 times, most recently
from
174de75 to
0b1d305
Compare
siddarthkay
force-pushed
the
fix-android-signing
branch
from
0b1d305 to
6d6918f
Compare
- points to `fix-android-signing` branch in status-jenkins-lib - use gradle build flavours for PR and Release. - signing config moved to gradle
siddarthkay
force-pushed
the
fix-android-signing
branch
from
1d44a8b to
f5fda2d
Compare
siddarthkay
changed the title
jrainville
approved these changes
Dec 22, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
I guess we'll need to cherry-pick this to the release/2.36.x branch?
jakubgs
approved these changes
Dec 23, 2025
|
|
||
| # Build with gradle directly to use product flavors | ||
| CUSTOM_ANDROID="$CWD/../android/qt${QT_MAJOR}" | ||
| ANDROID_BUILD="$BUILD_DIR/android-build" |
Member
There was a problem hiding this comment.
Seems like this should be defined and used earlier.
| # Copy custom res files (icons, styles, etc.) but preserve Qt-generated libs.xml | ||
| if [[ -d "$CUSTOM_ANDROID/res" ]]; then | ||
| # Copy everything except values/libs.xml (Qt generates that) | ||
| find "$CUSTOM_ANDROID/res" -type f ! -name "libs.xml" -exec sh -c ' |
Member
There was a problem hiding this comment.
It would be way simpler to just use rsync with --exclude.
Or you could enable extended glob with shopt -s extglob too, but that might be a bit obscure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix-android-signingbranch in status-jenkins-lib