feat(ActivityCenter): Integrate NotificationCard into new ActivityCenterPanel and add it to a new storybook page
#19616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On hover, the card now keeps the same background color while the border is highlighted using the primary color for clearer visual feedback. - Allow enabled property. - Prevention from undefined `attachments` property
…yCenterType`s Moved the `ActivityCenterGroup` enum out of `ActivityCenterStore` into the `ActivityCenterTypes` helper file to improve separation of concerns and keep type definitions centralized.
…enterTypes` Move `ActivityCenterReadType` out of the store and into `ActivityCenterTypes`to improve separation of concerns and make the type reusable across layers.
… roll, icon visibility API, and improved symmetric gradients - Refactored `StatusRollArea` to use a `Control` as the base type instead of `Item`, enabling native padding support and improving layout consistency. - Added `showIcon` property to both `StatusRollArea` and `StatusNavigationButton` for increased visual flexibility and clearer API semantics. - Updated `StatusNavigationButton` gradient background to ensure proper left/right symmetry and more polished visual behavior.
Replace `background: null` with an empty `Item` defining `opacity`
to avoid QML warnings ("QML PropertyAction: Cannot animate non-existent property "opacity"") caused by the Universal ScrollBar style
attempting to animate a non-existent opacity property.
…nt to int Ensure numeric fallback when deriving item counts from dynamic models, preventing QML warnings caused by assigning `undefined` to int properties.
…ignals, clarify naming, and enforce required props - Removed unused properties and signals to simplify the component API. - Renamed several properties for clearer behavior semantics and internal consistency. - Marked key properties as required to ensure correct usage at call sites and prevent silent misconfiguration. - Updated to use `StatusRollArea` directly instead of a plain `Item`, leveraging its built-in padding, scrolling behavior, and content handling. - Improved overall layout consistency and alignment according to design requirements.
…and testing page - Introduces the new `ActivityCenterPanel` as the foundation for the redesigned Activity Center experience. - Adds a dedicated Storybook/testing page to support development, review, and future iterations. - Integrates `ActivityCenterPopupTopBarPanel` into the panel structure. - Includes a minimal, non-final options menu to maintain existing behavior without blocking current workflows. - Includes layout composition and notification rendering by adopting the new `NotificationCard` component and clearer model/delegate boundaries. - Adds a fully mocked `NotificationsModel` covering all supported notification types, visual states, and UI variations in Status app. - Updates Spanish translations scoped to the Activity Center context. - Implements core interaction logic, including read/unread state handling, news-specific placeholders, and empty-state panels. Closes #18798
…New Design - Updated the Notifications empty state to align with the latest design. -Added new illustrations for a more polished and consistent visual experience. - Improved placeholder handling to correctly reflect the news enabled/disabled logic and its new design. - Updated translations accordingly, english and spanish. Closes #18905
-Renamed `ActivityCenterTypes.ActivityCenterNotificationType` to `ActivityCenterTypes.NotificationType` to remove redundancy. - Improves readability and consistency across the Activity Center types. - Added notification type to the mocked model.
noeliaSD
requested review from
a team,
alexjba,
caybro and
micieslak
as code owners
noeliaSD
requested review from
Khushboo-dev-cpp and
jrainville
and removed request for
a team
Member
Jenkins BuildsClick to see older builds (14)
|
jrainville
reviewed
Dec 19, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Awesome job! It's looks very good
| Layout.fillWidth: true | ||
|
|
||
| horizontalAlignment: Text.AlignHCenter | ||
| text: !root.newsEnabledViaRSS ? qsTr("Status News RSS are off") : |
Member
There was a problem hiding this comment.
I think it should be is off, since it's the setting that is off
| Layout.fillWidth: true | ||
|
|
||
| horizontalAlignment: Text.AlignHCenter | ||
| text: !root.newsEnabledViaRSS ? qsTr("Turn them on to get updates about new features and announcements. You can also enable this anytime in Privacy & Security settings.") : |
Member
There was a problem hiding this comment.
Then this would be:
Suggested change
| text: !root.newsEnabledViaRSS ? qsTr("Turn them on to get updates about new features and announcements. You can also enable this anytime in Privacy & Security settings.") : | |
| text: !root.newsEnabledViaRSS ? qsTr("Turn it on to get updates about new features and announcements. You can also enable this anytime in Privacy & Security settings.") : |
Member
There was a problem hiding this comment.
The name of the file doesn't look very kosher 😅 I feel like some OSes might dislike the spaces and/or commas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18798
Closes #18905
What does the PR do
Activity Centerrelated misc internal component improvements.ActivityCenterPanelas the foundation for the redesignedActivity Centerexperience.ActivityCenterPopupTopBarPanelinto the panel structure.NotificationCardcomponent and clearer model/delegate boundaries.NotificationsModelcovering all supported notificationtypes, visual states, and UI variations in Status app.
What's missing:
Activity Center Panelinto Floating Layout and App Navigation #18908Affected areas
storybookprototype.Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screen.Recording.2025-12-19.at.13.49.36.mov
Screen.Recording.2025-12-18.at.15.55.54.mov
Impact on end user
None
How to test
Play with the new
storybookpageRisk
None