WIP feat(PrimaryNavSidebar): integrate into AppMain and other flows #19623
+213
−959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins Builds
|
- remove now unused/obsolete components and SB pages - StatusSmartIdenticon: fix missing import - simplify ProfileButton by porting it to the StatusIconTabButton baseclass and fix the context menu opening/closing - fixup e2e locator types Fixes #19606
caybro
force-pushed
the
feat/19606-integrate-primary-nav-sidebar
branch
from
c5d6176 to
abe1cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #19606
Affected areas
AppMain
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
New AppMain navigation bar
How to test
Risk
mid