chore: don't enforce the HomePage as the start section #18672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
commented
Aug 20, 2025
| @@ -701,6 +701,8 @@ method load*[T]( | |||
| enabled = true, | |||
| ) | |||
| self.view.model().addItem(homePageSectionItem) | |||
| if activeSectionId == homePageSectionItem.id: | |||
There was a problem hiding this comment.
Remembering the HomePage as any other section
caybro
commented
Aug 20, 2025
| @@ -863,8 +865,9 @@ method load*[T]( | |||
| self.marketModule.load() | |||
|
|
|||
| # If the home page is enabled, we default to it as the opening section | |||
| if homePageEnabled: | |||
| activeSection = homePageSectionItem | |||
| # (disabled for 2.35 as per https://github.com/status-im/status-desktop/issues/18664, revisit after) | |||
There was a problem hiding this comment.
Disabled the part where we enforced the HomePage
There was a problem hiding this comment.
I thought we can just set homePageEnabled=false, no? 🤔
There was a problem hiding this comment.
Hmm no, we're not disabling the HomePage here, we're just restoring the old behavior where the last used section is remembered on the next app start
caybro
commented
Aug 20, 2025
Jenkins BuildsClick to see older builds (40)
|
caybro
requested review from
igor-sirotin and
anastasiyaig
and removed request for
glitchminer
jrainville
approved these changes
Aug 20, 2025
igor-sirotin
approved these changes
Aug 20, 2025
| @@ -863,8 +865,9 @@ method load*[T]( | |||
| self.marketModule.load() | |||
|
|
|||
| # If the home page is enabled, we default to it as the opening section | |||
| if homePageEnabled: | |||
| activeSection = homePageSectionItem | |||
| # (disabled for 2.35 as per https://github.com/status-im/status-desktop/issues/18664, revisit after) | |||
There was a problem hiding this comment.
I thought we can just set homePageEnabled=false, no? 🤔
It will, once the e2e is fixed |
anastasiyaig
force-pushed
the
18664-stop-showing-home-page-by-default-when-logging-in
branch
2 times, most recently
from
a379ab0 to
8682bc8
Compare
|
@anastasiyaig once e2e tests are fine, you can let me know. I'm taking over this PR while Lukas is off |
|
alright sure @jrainville its almost done, should be ready tomorrow |
anastasiyaig
force-pushed
the
18664-stop-showing-home-page-by-default-when-logging-in
branch
from
8682bc8 to
7963d06
Compare
- treat the HomePage as any other section Fixes #18664
anastasiyaig
force-pushed
the
18664-stop-showing-home-page-by-default-when-logging-in
branch
from
7963d06 to
baa5dec
Compare
anastasiyaig
force-pushed
the
18664-stop-showing-home-page-by-default-when-logging-in
branch
from
baa5dec to
5dd76b1
Compare
|
@jrainville i am done with my changes in this PR |
jrainville
deleted the
18664-stop-showing-home-page-by-default-when-logging-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #18664
Affected areas
AppMain
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Zaznam.obrazovky.z.2025-08-20.17-39-19.mp4
Impact on end user
No more special treatment of the HomePage, last active section will always be the one we start with the next time
How to test
Risk