feat: communities-in-own-shard-1 #6573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (121)
|
plopezlpz
force-pushed
the
feat/communities-in-own-shard-1
branch
from
1c84e47 to
37ef179
Compare
plopezlpz
changed the title
plopezlpz
changed the title
4 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6573 +/- ##
===========================================
- Coverage 59.51% 58.89% -0.63%
===========================================
Files 826 826
Lines 123599 123665 +66
===========================================
- Hits 73565 72830 -735
- Misses 42488 43248 +760
- Partials 7546 7587 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaichaosun
reviewed
May 13, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return filter, nil | ||
| // TODO temporary so not changing the return type, otherwise we should return a slice |
There was a problem hiding this comment.
This comment seems not applied here.
| @@ -24,7 +24,16 @@ func (m *Messenger) InitFilters() error { | |||
| rand.Seed(time.Now().Unix()) | |||
|
|
|||
| // Community requests will arrive in this pubsub topic | |||
| if err := m.SubscribeToPubsubTopic(wakuv2.DefaultNonProtectedPubsubTopic(), nil); err != nil { | |||
| // TODO depracate | |||
There was a problem hiding this comment.
I noticed that there are a few todos in the PR, would be good to have issue linked here to resolve the todos.
plopezlpz
force-pushed
the
feat/communities-in-own-shard-1
branch
from
c2c290b to
ba90867
Compare
plopezlpz
changed the title
…ies-in-own-shard-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow communities to be eventually moved to shards
128and256. We will follow these migration stages:32,64and custom) together with the new shards (128and256).128and256).32and64.TODO:
128and256in status-desktop128: https://status.app/cc/G3EAAGRgnoPjHJmoytKJg-CQA4dvgWZZoJAGHrKX8kg1pW4UfiyRnZZT1CSDHm6veZC66zje5_L6K7iaprlb1zpDQddFYxEUJ1_LuiCKm76zkmGMrTDMBqvthtTK2q5x467N-qwF#zQ3shrzwZiRa1r7xu2soYJunvHzsi79ANkoCXnARnpJajhq2GRelates to #6384