Skip to content

Conversation

dlipicar
Copy link
Contributor

@dlipicar dlipicar commented Jul 11, 2025

status-desktop PR: status-im/status-desktop#18345
Blocked by: status-im/status-desktop#18346

Replace multiple API keys for Alchemy (one per chain) with a single one, according to https://www.alchemy.com/blog/the-future-is-multichain

Copy link

github-actions bot commented Jul 11, 2025

Looks like you have BREAKING CHANGES in your PR.
Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

@status-im-auto
Copy link
Member

status-im-auto commented Jul 11, 2025

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3970817 #1 2025-07-11 18:37:18 ~2 min android 📦aar
✔️ 3970817 #1 2025-07-11 18:38:11 ~3 min linux 📦zip
✔️ 3970817 #1 2025-07-11 18:39:08 ~4 min macos 📦zip
✔️ 3970817 #1 2025-07-11 18:39:37 ~4 min ios 📦zip
✔️ 3970817 #1 2025-07-11 18:40:03 ~4 min windows 📦zip
✔️ 3970817 #1 2025-07-11 18:40:18 ~5 min macos 📦zip
✔️ 3970817 #1 2025-07-11 18:42:11 ~6 min tests-rpc 📄log
✔️ 3970817 #1 2025-07-11 18:45:17 ~10 min linux 📦zip
✖️ 3970817 #1 2025-07-11 19:00:01 ~24 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6071c84 #2 2025-07-15 13:46:10 ~2 min android 📦aar
✔️ 6071c84 #2 2025-07-15 13:47:27 ~3 min linux 📦zip
✔️ 6071c84 #2 2025-07-15 13:48:57 ~4 min macos 📦zip
✔️ 6071c84 #2 2025-07-15 13:50:26 ~6 min ios 📦zip
✔️ 6071c84 #2 2025-07-15 13:51:39 ~7 min tests-rpc 📄log
✔️ 6071c84 #2 2025-07-15 13:51:56 ~7 min windows 📦zip
✔️ 6071c84 #2 2025-07-15 13:52:21 ~8 min macos 📦zip
✔️ 6071c84 #2 2025-07-15 13:54:58 ~11 min linux 📦zip
✔️ 6071c84 #2 2025-07-15 14:09:23 ~25 min tests 📄log
fb198f3 #3 2025-08-28 20:40:03 ~1 min android 📄log
fb198f3 #3 2025-08-28 20:41:47 ~2 min ios 📄log
✔️ fb198f3 #3 2025-08-28 20:42:04 ~3 min linux/status-go 📦zip
✔️ fb198f3 #3 2025-08-28 20:42:45 ~3 min macos/status-go 📦zip
✔️ fb198f3 #3 2025-08-28 20:44:08 ~5 min windows/status-go 📦zip
✔️ fb198f3 #3 2025-08-28 20:47:15 ~8 min tests-rpc 📄log
✔️ fb198f3 #3 2025-08-28 20:49:16 ~10 min linux/nwaku 📦zip
✔️ fb198f3 #3 2025-08-28 21:02:40 ~23 min tests 📄log

Copy link
Contributor

@friofry friofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vkjr
Copy link
Contributor

vkjr commented Jul 15, 2025

@dlipicar, thanks looks good!
Is there a corresponding status-desktop PR?

Also right now I have 2 env vars set:
STATUS_BUILD_ALCHEMY_OPTIMISM_MAINNET_TOKEN and STATUS_BUILD_ALCHEMY_ARBITRUM_MAINNET_TOKEN. They both have different values. Which one of them should I use later when client will use single token?

@dlipicar
Copy link
Contributor Author

dlipicar commented Jul 15, 2025

@dlipicar, thanks looks good! Is there a corresponding status-desktop PR?

Also right now I have 2 env vars set: STATUS_BUILD_ALCHEMY_OPTIMISM_MAINNET_TOKEN and STATUS_BUILD_ALCHEMY_ARBITRUM_MAINNET_TOKEN. They both have different values. Which one of them should I use later when client will use single token?

any of them will do.

Added status-desktop PR to the description

@dlipicar dlipicar force-pushed the chore/use-single-alchemy-api-key branch from 3970817 to 6071c84 Compare July 15, 2025 13:43
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.97%. Comparing base (78449f1) to head (fb198f3).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...s/wallet/thirdparty/collectibles/alchemy/client.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6747      +/-   ##
===========================================
- Coverage    59.24%   58.97%   -0.27%     
===========================================
  Files          829      828       -1     
  Lines       122311   122283      -28     
===========================================
- Hits         72461    72115     -346     
- Misses       42332    42659     +327     
+ Partials      7518     7509       -9     
Flag Coverage Δ
functional 30.51% <45.45%> (-0.92%) ⬇️
unit 55.42% <72.72%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/defaults.go 74.11% <100.00%> (-1.73%) ⬇️
params/config.go 86.58% <ø> (ø)
protocol/requests/create_account.go 36.84% <ø> (ø)
services/wallet/service.go 73.39% <100.00%> (-9.36%) ⬇️
...s/wallet/thirdparty/collectibles/alchemy/client.go 25.14% <62.50%> (-0.45%) ⬇️

... and 58 files with indirect coverage changes

@dlipicar dlipicar force-pushed the chore/use-single-alchemy-api-key branch from 6071c84 to fb198f3 Compare August 28, 2025 20:38
@dlipicar dlipicar merged commit d03b7b5 into develop Aug 29, 2025
20 of 22 checks passed
@dlipicar dlipicar deleted the chore/use-single-alchemy-api-key branch August 29, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants