-
Notifications
You must be signed in to change notification settings - Fork 259
chore!: use single alchemy api key for all chains #6747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like you have BREAKING CHANGES in your PR. Check-list
|
Jenkins BuildsClick to see older builds (9)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@dlipicar, thanks looks good! Also right now I have 2 env vars set: |
any of them will do. Added status-desktop PR to the description |
3970817
to
6071c84
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6747 +/- ##
===========================================
- Coverage 59.24% 58.97% -0.27%
===========================================
Files 829 828 -1
Lines 122311 122283 -28
===========================================
- Hits 72461 72115 -346
- Misses 42332 42659 +327
+ Partials 7518 7509 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6071c84
to
fb198f3
Compare
status-desktop PR: status-im/status-desktop#18345
Blocked by: status-im/status-desktop#18346
Replace multiple API keys for Alchemy (one per chain) with a single one, according to https://www.alchemy.com/blog/the-future-is-multichain