fix: rework collectibles commands into loaders, fix accounts change … #6845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (66)
|
dlipicar
force-pushed
the
fix/collectibles-controller-loaders
branch
2 times, most recently
from
d70b958 to
775c08d
Compare
dlipicar
changed the title
dlipicar
force-pushed
the
fix/collectibles-controller-loaders
branch
4 times, most recently
from
16490da to
4d2d7f4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6845 +/- ##
===========================================
- Coverage 58.91% 58.81% -0.10%
===========================================
Files 824 825 +1
Lines 121822 122029 +207
===========================================
+ Hits 71769 71776 +7
- Misses 42572 42773 +201
+ Partials 7481 7480 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlipicar
force-pushed
the
fix/collectibles-controller-loaders
branch
from
4d2d7f4 to
cc707a9
Compare
saledjenic
approved these changes
Aug 22, 2025
dlipicar
force-pushed
the
fix/collectibles-controller-loaders
branch
from
cc707a9 to
6dc5474
Compare
alaibe
approved these changes
Aug 27, 2025
dlipicar
force-pushed
the
fix/collectibles-controller-loaders
branch
from
6dc5474 to
81f3e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…callback
Fixes status-im/status-desktop#18568
The collectibles controller commands were hard to follow and the threading model was quite messy, causing issues like the one linked. This PR reworks the controller into 3 parts, which were moved to a separate package:
loadOwnedCollectiblesCommand): in charge of refreshing the full list of owned collectibles for a given Account+ChainID, storing the results in the db and emitting events about the load progress.periodicRefreshOwnedCollectiblesCommand): in charge of running the Loaders at a given period for a given Account+ChainIDWalletEvent sending was extracted to the Service, hopefully we'll get rid of those in the near future.