-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: patch to use newer BlurView pom file #21095
Conversation
Jenkins BuildsClick to see older builds (8)
|
9559c90
to
2865394
Compare
- implementation 'com.github.Dimezis:BlurView:version-2.0.3' | ||
+ implementation 'com.github.Dimezis:BlurView:version-2.0.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work, as the version of Node modules we use in gradle
Nix shell is not patched:
Lines 53 to 58 in 7b34a4f
# WARNING: Unpatched Node.js deps allow Gradle to use remote repos. | |
"$STATUS_MOBILE_HOME/nix/scripts/node_modules.sh" ${pkgs.deps.nodejs} | |
function restore_patched_modules() { | |
"$STATUS_MOBILE_HOME/nix/scripts/node_modules.sh" ${pkgs.deps.nodejs-patched} | |
} | |
trap restore_patched_modules EXIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I've removed this block and it seems like the patched deps are fetched now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possibility is to split patching of nodejs
derivation into two stages: nodejs-patched
and nodejs-offline
. That way we can use the patched version without using the version that modifies Gradle configs to not reference remote repositories.
Though at the same time, I kinda wonder if that second type of patching is still necessary.
bf3be44
to
cbac912
Compare
cbac912
to
c4070e8
Compare
This needs more work, converting to Draft |
Are we abandoning the idea of 3-stage patched nodes? Or the multi-repo Gradle configs? |
Summary
This PR patches blur view library to use
com.github.Dimezis:BlurView:version-2.0.4
instead ofcom.github.Dimezis:BlurView:version-2.0.3
version 2.0.4 seems more reliable :
In this PR we also make sure that gradle deps are generated for patched nodejs deps.
Platforms
status: ready