You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@seanstrom thank you for the PR. Tested: mentioned links are being opened successfully. If there are no other places which need to be checked for regression - this PR is ready for merge. In case this PR could affect any other places related to urls opening, please let me know.
@pavloburykh is it possible to test the app's dApp functionality? I think there's some features that open a url when connecting to a dApp from the status mobile app.
@pavloburykh is it possible to test the app's dApp functionality? I think there's some features that open a url when connecting to a dApp from the status mobile app.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20377
follow-up pr: #20752
Summary
rn/open-url
(for opening links) torf/dispatch
with the:open-url
event:open-url
Re-Frame eventPlatforms
Areas that maybe impacted
Functional
Steps to test
Before and after screenshots comparison
After Changes
Opening links from the buy crypto bottom-sheet
Screen.Recording.2024-09-10.at.17.06.43.mov
Opening the read-more link from the account creation info
Screen.Recording.2024-09-10.at.17.07.36.mov
status: ready