feat: implement proper error handling for swaps #21261
Open
+174
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (41)
|
briansztamfater
force-pushed
the
feat/swap-error-handling
branch
2 times, most recently
from
fb68f41
to
232576a
Compare
|
Hi @briansztamfater, should this PR be tested now, or is it better to wait until the status changes from 'draft' to 'open'? |
|
Hey @VolodLytvynenko, this is almost ready, but I think it is better to first verify #21179 is correctly tested, because status-go latest changes introduced some bugs in the mobile client and would make difficult to test this PR. Once we merge #21179 I will rebase this one, solve the conflicts and send it to review. |
VolodLytvynenko
force-pushed
the
feat/swap-error-handling
branch
from
645c3b1
to
b22b49a
Compare
briansztamfater
force-pushed
the
feat/swap-error-handling
branch
from
b22b49a
to
90488f5
Compare
briansztamfater
requested review from
alwx,
shivekkhurana,
vkjr,
smohamedjavid,
clauxx and
mohsen-ghafouri
briansztamfater
changed the title
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/swap-error-handling
branch
from
8c75a74
to
50343db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20342
fixes #20271
Summary
This PR implements error handling for swap proposal errors.
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready