[#21132] refactor: improve send transaction content in wc flow #21266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (17)
|
mohsen-ghafouri
force-pushed
the
feat/improve-wc-send-transaction
branch
4 times, most recently
from
cafb546
to
551d423
Compare
mohsen-ghafouri
force-pushed
the
feat/improve-wc-send-transaction
branch
from
551d423
to
391edbc
Compare
mohsen-ghafouri
force-pushed
the
feat/improve-wc-send-transaction
branch
from
391edbc
to
05bc48e
Compare
mohsen-ghafouri
requested review from
shivekkhurana,
briansztamfater and
clauxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21132
Summary
We should improve the UX of the transactions modal, where, as of now, we just show the raw json transaction (just formatting the values from hex to utf-8, so they’re human readable).
Areas that maybe impacted
Steps to test
Result
Simulator.Screen.Recording.-.iPhone.13.-.2024-09-16.at.14.59.13.mp4
status: ready