nix: point to nixpkgs unstable channel for gradle 8.8 #21267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (45)
|
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
2 times, most recently
from
58b55b4
to
17180a0
Compare
3 tasks
siddarthkay
requested review from
yakimant,
apentori,
markoburcul and
mendelskiv93
|
Hey hey @status-im/mobile @status-im/wallet-mobile-devs : Please check if the changes in this PR cause any issues with your local dev environments. |
|
I cleaned and built the ios app - everything seems okay so far ✅ for context I'm on macOS 13.6.7 |
|
Also, if all the commits here are necessary to make the upgrade work I would squash them into one commit with all the context in the description. You can combine the titles of existing commits as a list for the commit description. |
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
from
17180a0
to
9ed6679
Compare
ilmotta
approved these changes
Sep 18, 2024
|
@status-im/mobile-qa : This PR also needs just a smoke test, we upgrade all our build tools here when we move to newer |
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
2 times, most recently
from
f880a86
to
6dc9412
Compare
apentori
approved these changes
Sep 19, 2024
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
2 times, most recently
from
c6fe507
to
22f6278
Compare
|
@siddarthkay on my way to test it! |
0% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletMultipleDevice:
|
nix: ldflags are expected to be a list chore: fix deprecated vendorSha256 nix: bump jdk to 17 & pass java version to gradle make: set universalApk false in run-android target nix: fix --replace deprecation warning - NixOS/nixpkgs#260776 ios: update pod and gem lockfiles nix: bump nodejs to 20.12.2 nix: add Xcode 16.0 to allowed versions chore: upgrade rn-image-crop-picker lib nix: full path for missing dep in node_modules sh
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
from
e64d894
to
3c5b671
Compare
100% of end-end tests have passedPassed tests (7)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
100% of end-end tests have passedPassed tests (51)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
|
Hey @siddarthkay ! Did smoke, all good. |
|
@siddarthkay, missed that. Could we have gradle from unstable and everything else from stable? |
|
@yakimant : The easiest way to do that in existing setup could be to update our fork of |
|
@siddarthkay not true. You can have however many |
|
ah then what you suggest is indeed easier @jakubgs |
|
An attempt is here -> #21374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bump in
nixpkgsis needed forreact-nativeupgrade tov0.75A summary of upgraded packages is below :
openjdkfrom11->17gradlefrom8.4->8.8gitfrom2.42.0->2.44.1NodeJSfrom18.19.1->20.12.2Pythonfrom3.10.13->3.10.14Clojurefrom1.11.1.1413->1.11.3.1463Cocoapodsfrom1.13.0->1.15.2Platforms
status: ready