[#21270] - Collectibles stuck in loading for watch only accounts #21286

ulisesmac · 2024-09-19T01:37:33Z

Summary

This PR fixes the exception thrown on Android when a loading collectible is pressed.

⚠️ ATM I can't test on iOS, I really appreaciate QA help testing that the loading state and collectible behavior hasn't changed on iOS ⚠️

⚠️ Important note

Although this PR solves the exception, the root issue (collectibles are stuck in a loading state) happen sometimes.

It was reported in:

Collectibles not displayed after account recovery and after watch only account is added until relogin #18613

And we tried to solve it in:

fix(wallet): Collectibles not fetched for new and recovered accounts #20961

But it's still reproducible (waited for more than a minute, and actually after 15mins they never loaded):

Screencast.from.2024-09-18.19-17-40.mp4

What is this PR doing then?

This PR:
✅ Fixes the loading collectible state on Android (it only worked on iOS)
✅ When the user presses a loading collectible, it won't throw any error/exception.

Review notes

I'll reopen the root issue.

Platforms

Android
iOS

Steps to test

[Android]

Open Status in a fresh install
Create a new Status profile
Disable test networks (if they were enabled)
Add a watched address, you can pick any of the addresses listed in this issue, e.g. 0x00000000219ab540356cbb839cbe05303d7705fa
Switch to the collectibles tab
If they are stuck in a loading state, you can press them and no exception will be thrown.

[iOS]

Make sure the collectibles are still stuck in a loading state and nothing is broken (pressing, opening a collectible, scrolling).

status: ready

status-im-auto · 2024-09-19T01:42:22Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`16b7726`	#1	2024-09-19 01:42:20	~4 min	`tests`	📄`log`
✔️	`16b7726`	#1	2024-09-19 01:45:31	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`16b7726`	#1	2024-09-19 01:45:57	~8 min	`android`	🤖`apk` 📲
✔️	`16b7726`	#1	2024-09-19 01:48:07	~10 min	`ios`	📱`ipa` 📲

✔️	`7ee38b0`	#2	2024-09-20 12:33:33	~4 min	`tests`	📄`log`
✔️	`7ee38b0`	#2	2024-09-20 12:37:30	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`7ee38b0`	#2	2024-09-20 12:37:31	~8 min	`android`	🤖`apk` 📲
✔️	`7ee38b0`	#2	2024-09-20 12:43:22	~14 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`90aaf52`	#3	2024-09-24 01:29:15	~4 min	`tests`	📄`log`
✔️	`90aaf52`	#3	2024-09-24 01:30:52	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`90aaf52`	#3	2024-09-24 01:32:29	~7 min	`android`	🤖`apk` 📲
✔️	`90aaf52`	#3	2024-09-24 01:34:29	~9 min	`ios`	📱`ipa` 📲

✔️	`ad74b1c`	#4	2024-09-24 22:10:47	~4 min	`tests`	📄`log`
✔️	`ad74b1c`	#4	2024-09-24 22:13:11	~6 min	`android`	🤖`apk` 📲
✔️	`ad74b1c`	#4	2024-09-24 22:13:44	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ad74b1c`	#4	2024-09-24 22:15:59	~9 min	`ios`	📱`ipa` 📲

ulisesmac

Although this PR is fixing the loading? logic, I'm not too happy with the solution.

The loading? property previously added seems not reactive (i.e. if it's true when the component is mounted and then switched to false, it'll be ignored). Although it works because we are re-mounting the listing, seems not clean.

IMO, the property could have been named :always-loading? to clearly show its purpose.

Now with the changes, the loading? property is being checked during the calculation of the component, but we are still remounting the listing to switch from "collectibles loading" -> "loaded collectibles".

smohamedjavid

Thanks for fixing this @ulisesmac 🙌

IMO, the property could have been named :always-loading? to clearly show its purpose.

I have no strong opinion on this. The component is supposed to have a prop status with values accepted as default or loading. However, the component handles the loading state due to the image fetching. Hence, the loading? prop is introduced to be controllable from the parent without many changes in the component (I don't want to break the component, as it's essential to handle the image loading time). I'm fine with any name 👍 .

status-im-auto · 2024-09-20T13:20:05Z

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 2
Expected to fail tests: 0
Passed tests: 5

IDs of failed tests: 702745,727229

Failed tests (2)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Tap on found: Button
Device 2: Find `Text` by `xpath`: `//*[@resource-id='android:id/content_preview_text']`

Test setup failed: critical/chats/test_1_1_public_chats.py:31: in prepare_devices
    self.public_key_2 = self.home_2.get_public_key()
../views/home_view.py:590: in get_public_key
    link_to_profile = self.get_link_to_profile()
../views/home_view.py:584: in get_link_to_profile
    link_to_profile = self.sharing_text_native.text
../views/base_element.py:419: in text
    text = self.find_element().text
../views/base_element.py:84: in find_element
    raise exception
../views/base_element.py:77: in find_element
    return self.driver.find_element(self.by, self.locator)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:409: in find_element
    return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value']
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up
E   Stacktrace:
E   UnknownError: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up
E       at UIA2Proxy.command (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/jsonwp-proxy/proxy.js:355:13)
E       at processTicksAndRejections (node:internal/process/task_queues:95:5)
E       at AndroidUiautomator2Driver.helpers.doFindElementOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/lib/commands/find.js:30:10)
E       at doFind (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:36:17)
E       at wrappedCondFn (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:137:14)
E       at spin (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:221:20)
E       at waitForCondition (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:238:10)
E       at AndroidUiautomator2Driver.implicitWaitForCondition (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:139:12)
E       at AndroidUiautomator2Driver.findElOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:60:5)
E       at AndroidUiautomator2Driver.findElOrElsWithProcessing (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:60:12)
E       at AndroidUiautomator2Driver.findElement (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:75:12)

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
Device 2: Text is 0.06579 ETH

critical/test_wallet.py:159: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4175 but expected to be 0.4176

Passed tests (5)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-09-23T10:14:13Z

43% of end-end tests have passed

Total executed tests: 7
Failed tests: 4
Expected to fail tests: 0
Passed tests: 3

IDs of failed tests: 727230,702742,703133,727229

Failed tests (4)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:29: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:303: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
2. test_wallet_send_eth, id: 727229
Device 1: Find `Button` by `xpath`: `//[@text="Cancel" or @text="CANCEL"]` Device 1: Tap on found: Button Test setup failed: critical/test_wallet.py:29: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, **self.kwargs) ../views/sign_in_view.py:303: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Find `Button` by `xpath`: `//*[@text="Cancel" or @text="CANCEL"]` Device 1: Tap on found: Button Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:274: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:274: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

Passed tests (3)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-09-23T10:29:45Z

50% of end-end tests have passed

Total executed tests: 4
Failed tests: 2
Expected to fail tests: 0
Passed tests: 2

IDs of failed tests: 727230,727229

Failed tests (2)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:29: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:303: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
2. test_wallet_send_eth, id: 727229
Device 2: Find `Button` by `xpath`: `//[@text="Cancel" or @text="CANCEL"]` Device 2: Tap on found: Button Test setup failed: critical/test_wallet.py:29: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, **self.kwargs) ../views/sign_in_view.py:303: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

Passed tests (2)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs

mariia-skrypnyk · 2024-09-23T10:39:57Z

Hi @ulisesmac !

Thanks for your fix.
I've checked it on both platforms.
Loading on iOS was less then 1 sec, Android was 2 sec approx.
And no error anymore when you opens particular image.
Great job!

ulisesmac requested review from smohamedjavid and a team September 19, 2024 01:37

ulisesmac self-assigned this Sep 19, 2024

ulisesmac mentioned this pull request Sep 19, 2024

Collectibles not displayed after account recovery and after watch only account is added until relogin #18613

Closed

ulisesmac commented Sep 19, 2024

View reviewed changes

vkjr approved these changes Sep 19, 2024

View reviewed changes

smohamedjavid approved these changes Sep 19, 2024

View reviewed changes

ulisesmac added the request-manual-qa label Sep 19, 2024

mariia-skrypnyk force-pushed the 21270-collectibles-stuck-watch-only-accs branch from 16b7726 to 7ee38b0 Compare September 20, 2024 12:29

mariia-skrypnyk self-assigned this Sep 20, 2024

mariia-skrypnyk added the Tested - OK label Sep 23, 2024

ulisesmac added 2 commits September 24, 2024 16:05

Fix loading? state for collectible cards

c24a976

Lint fix

ad74b1c

ulisesmac force-pushed the 21270-collectibles-stuck-watch-only-accs branch from 90aaf52 to ad74b1c Compare September 24, 2024 22:06

ulisesmac merged commit 5df1e6c into develop Sep 24, 2024
6 checks passed

ulisesmac deleted the 21270-collectibles-stuck-watch-only-accs branch September 24, 2024 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#21270] - Collectibles stuck in loading for watch only accounts #21286

[#21270] - Collectibles stuck in loading for watch only accounts #21286

ulisesmac commented Sep 19, 2024

status-im-auto commented Sep 19, 2024 •

edited

Loading

ulisesmac left a comment

smohamedjavid left a comment

status-im-auto commented Sep 20, 2024

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Sep 23, 2024

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Sep 23, 2024

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

mariia-skrypnyk commented Sep 23, 2024

[#21270] - Collectibles stuck in loading for watch only accounts #21286

[#21270] - Collectibles stuck in loading for watch only accounts #21286

Conversation

ulisesmac commented Sep 19, 2024

Summary

⚠️ Important note

What is this PR doing then?

Review notes

Platforms

Steps to test

status-im-auto commented Sep 19, 2024 • edited Loading

Jenkins Builds

ulisesmac left a comment

Choose a reason for hiding this comment

smohamedjavid left a comment

Choose a reason for hiding this comment

status-im-auto commented Sep 20, 2024

71% of end-end tests have passed

Failed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Passed tests (5)

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Sep 23, 2024

43% of end-end tests have passed

Failed tests (4)

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Passed tests (3)

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Sep 23, 2024

50% of end-end tests have passed

Failed tests (2)

Class TestWalletMultipleDevice:

Passed tests (2)

Class TestCommunityOneDeviceMerged:

mariia-skrypnyk commented Sep 23, 2024

status-im-auto commented Sep 19, 2024 •

edited

Loading