-
Notifications
You must be signed in to change notification settings - Fork 3
Add Filesystem datastore support #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds Filesystem as a supported datastore type to enable local storage for quickstart deployments without requiring cloud storage configuration. The changes upgrade the go-stellar-sdk dependency to include the FilesystemDataStore implementation and update the example configuration to document the new storage option.
- Upgrades go-stellar-sdk dependency to version containing FilesystemDataStore implementation
- Adds Filesystem datastore configuration documentation with destination_path and write_metadata parameters
- Updates datastore type comment to list Filesystem alongside GCS and S3
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.sum | Updates checksums for the upgraded go-stellar-sdk dependency |
| go.mod | Adds replace directive to pin go-stellar-sdk to specific version |
| config/config.example.toml | Documents Filesystem datastore configuration parameters and updates datastore type comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
sreuland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, including the pending TODO task.
What
Add Filesystem as a supported datastore type alongside GCS and S3. Update example configuration with destination_path and write_metadata parameters. Upgrade go-stellar-sdk dependency to include FilesystemDataStore implementation.
Why
Enable quickstart to publish a meta lake locally without requiring cloud storage configuration (GCS/S3) to support integration testing with galexie with quickstart.
Related:
Dependent on:
Close stellar/quickstart#835