Skip to content

Conversation

@leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jan 6, 2026

What

Add Filesystem as a supported datastore type alongside GCS and S3. Update example configuration with destination_path and write_metadata parameters. Upgrade go-stellar-sdk dependency to include FilesystemDataStore implementation.

Why

Enable quickstart to publish a meta lake locally without requiring cloud storage configuration (GCS/S3) to support integration testing with galexie with quickstart.

Related:

Dependent on:

Close stellar/quickstart#835

@socket-security
Copy link

socket-security bot commented Jan 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgithub.com/​stellar/​go-stellar-sdk@​v0.0.0-20251210093830-27970a00c2d7 ⏵ v0.0.0-20260108045717-08ad73d9ed0e75 +1100100100100

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds Filesystem as a supported datastore type to enable local storage for quickstart deployments without requiring cloud storage configuration. The changes upgrade the go-stellar-sdk dependency to include the FilesystemDataStore implementation and update the example configuration to document the new storage option.

  • Upgrades go-stellar-sdk dependency to version containing FilesystemDataStore implementation
  • Adds Filesystem datastore configuration documentation with destination_path and write_metadata parameters
  • Updates datastore type comment to list Filesystem alongside GCS and S3

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
go.sum Updates checksums for the upgraded go-stellar-sdk dependency
go.mod Adds replace directive to pin go-stellar-sdk to specific version
config/config.example.toml Documents Filesystem datastore configuration parameters and updates datastore type comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@socket-security
Copy link

socket-security bot commented Jan 6, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@leighmcculloch leighmcculloch marked this pull request as ready for review January 6, 2026 22:48
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, including the pending TODO task.

@leighmcculloch leighmcculloch enabled auto-merge (squash) January 8, 2026 03:21
@leighmcculloch
Copy link
Member Author

@sreuland I addressed the comment about avoiding resetting the variable another way by removing the variable all together since it is a fixed value we can derive. See 0ac51b9.

@leighmcculloch leighmcculloch enabled auto-merge (squash) January 8, 2026 05:58
@leighmcculloch leighmcculloch merged commit 2b90d6b into main Jan 8, 2026
17 checks passed
@leighmcculloch leighmcculloch deleted the add-filesystem-datastore-support branch January 8, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add galexie meta lake

3 participants