Add exclude option (no new dependency added) #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple logic to exclude specific URLs from crawl queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main reason why I added this was because I was generating a static build for a simple site, but for some reason it crawls a url with a different domain (localhost with different port). I would try and investigate the localhost issue, but having an exclude option will cover future problems as well.
excludein thedefaultOptions(not sure how to properly update the snapshot 🤷).Feel free to close, but so far tests are good. I will use the forked version for my use case right now, but having it in the main repo would be nicer.
Cheers!