Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

yehorchernenko
Copy link

Fix the case when request is refused because metadata has unsupported symbols

@yehorchernenko
Copy link
Author

@stevapple Please take a look 🙏

@stevapple
Copy link
Owner

Thanks for fixing this and helping with Swift Concurrency migration! @yehorchernenko

For using Task and async/await we'd better bump the minimum Swift requirement to 5.5 first. The implementation itself looks good and I'm going to merge once I can confirm it's compatible with both Linux and macOS. Hopefully a basic CI pipeline could be set up soon.

@dev-onepayclick
Copy link

dev-onepayclick commented Jul 3, 2023

Hi @stevapple :)

I'm implementing this package on my project and after some hours of debugging I came with the same fix that Yehor is proposing (escaping the metadata)
image

It would be great if this could be merged ❤️

@stevapple
Copy link
Owner

Hi @dev-onepayclick! Thanks for your reply. I would be glad to apply the fix, but I think this PR is adding too many stuffs other than the fix now. Some of them (namely bumping Swift and platform version requirements) are unnecessary for the fix, and still needs careful design.

@yehorchernenko Would you mind splitting all unrelated changes into a separate PR, making this a simple, 1-line change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants