StimulusReflex::Element and StimulusReflex Targets#687
Draft
Matt-Yorkley wants to merge 15 commits intostimulusreflex:mainfrom
Draft
StimulusReflex::Element and StimulusReflex Targets#687Matt-Yorkley wants to merge 15 commits intostimulusreflex:mainfrom
Matt-Yorkley wants to merge 15 commits intostimulusreflex:mainfrom
Conversation
✅ Deploy Preview for stimulusreflex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Fixes failing "selector can be overwritten" test in ReflexElementTest
… in StimulusReflex::Logger
7c7f258 to
4ab5b60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Description
Finishes off the proposed StimulusReflex Element and Stimulusreflex Targets features previously started in #489 and #490.
Adds named
element(the element which called the reflex) and definabletargetsa little bit like theTargets APIin Stimulus, which can be interacted with in reflexes by applying (chainable)cable_readyoperations which can omit theselectorargument, eg:The above examples are all converted automatically into valid
cable_readyoperations against single or multiple targets (collections of targets with the same name), and broadcast at the end of the reflex.Defining targets and scoping targets
By default a reflex will not send targets data from the client side. Targets can be sent by setting the
data-include-targetsproperty (any truthy value) or targets can be restricted to elements within the parent controller by settingdata-include-targets="controller", eg:Checklist