Skip to content

Conversation

@harryjwright
Copy link
Contributor

Currently, Adc::new has a trait bound for Calibrate. While ADC1 has a full calibration implementation for internal signals, ADC2 and ADC3 do not.

This PR adds the missing stub implementations:

impl Calibrate for Adc<pac::ADC2> {} (gated by adc2 feature)

impl Calibrate for Adc<pac::ADC3> {} (gated by adc3 feature)

This allows users to use the standard Adc::new constructor for these peripherals instead of manual struct initialization.

@burrbull
Copy link
Member

Add change to Changelog please

@harryjwright
Copy link
Contributor Author

Changelog updated! Thanks for the catch.

@burrbull burrbull added this pull request to the merge queue Jan 11, 2026
Merged via the queue into stm32-rs:master with commit 7f96050 Jan 11, 2026
22 checks passed
@linuxtim
Copy link

git log entry for the master branch includes:

commit 172ccc0fa26a071b04a5f4de61cfb9d73adc7c98
Author: harryjwright <[email protected]>
Date:   Sun Jan 11 03:23:25 2026 +0000
    
    Add changelog entry for [#YOUR_PR_NUMBER]

Not sure if/how you want to fix this up? More generally it might be better to include the changelog commit into the code commit (i.e. rebase)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants