Enable *and* reset gpio in split method #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
commented
Jan 30, 2025
src/gpio.rs
Outdated
| @@ -14,7 +14,7 @@ pub trait GpioExt { | |||
| type Parts; | |||
|
|
|||
| /// Splits the GPIO block into independent pins and registers | |||
| fn split(self, rcc: &mut Rcc) -> Self::Parts; | |||
| fn split(self, rcc: &Rcc) -> Self::Parts; | |||
There was a problem hiding this comment.
Also, unrelated to #180, since Enable::enable and Reset::reset use bit banding, we do not need exclusive access to the rcc right?
There was a problem hiding this comment.
Will remove this and perhaps do that later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AdinAck and @burrbull , do you believe this is the actual fix for #180 ?