Add support for GD32VF103 chips #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aronlejla12
approved these changes
Mar 8, 2022
|
@Disasm Is this PR completed yet? |
|
@katyo this PR is completed, but it needs to be rebased to the latest head and then tested again. |
|
@Disasm I rebased it and seems test class example works for me now! |
Disasm
force-pushed
the
gd32v-ng
branch
2 times, most recently
from
2951fbb to
995e542
Compare
Disasm
force-pushed
the
gd32v-ng
branch
3 times, most recently
from
24ffab6 to
b645a4d
Compare
|
@Disasm Would it be possible to get this PR merged? The patches also seem to work for ARM-based gd32c103 chips which apparently use the same variant of the peripheral. |
|
Tested with the following boards:
No regressions found from this PR across all the tests executed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on: