fix(deserializer): handle array value from uri-template-lite in simple style path params#2801
Draft
b-wulan wants to merge 1 commit into
Draft
Conversation
…e style path params
When uri-template-lite parses a comma-separated path param (e.g. /codes/123,456
against /codes/{codeIds}), it returns a string[] rather than a string.
deserializeArray assumed a string and crashed with "value.split is not a function".
Guard against the already-parsed array so both shapes are handled correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uri-template-litereturnsstring[](notstring) when it parses a comma-separated path param — e.g. matching/codes/123,456against/codes/{codeIds}yields{ codeIds: ["123","456"] }.deserializeArrayassumed a plain string and crashed withTypeError: value.split is not a function(reported in #2710).The fix adds an
Array.isArrayguard: if the value is already a parsed array, return it directly; otherwise split as before.